Supports oneof fields in more places #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yugui
commented
Jun 17, 2017
yugui
commented
- root of the request body: fixes oneof fields are not supported as the "body"? #413
- path parameters
The idea behind the change is similar to golang/protobuf#283. But it returns a non-nil pointer to an oneof option struct for ease of use in both of unmarshaling and assignment.
|
I noticed that the alloc function does not work when the target message is defined outside of the current package. I'll rewrite this PR. |
|
@yugui What's the current state of this? |
|
Although it's relatively easy to find a workaround when in need of such a message structure, supporting Is there any help needed to push this PR forward? |
1 task
|
This is replaced by #634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.